Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

Issue 2081383004: SoM: Added notice about chromium webkit failures + documentation links. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Changed logic to just check the tree. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
index c1ac8d239e41f856d2f9997704ff599a8d2ac9c0..a3f8298cee3d37a014103b9bf61d588c10868d0e 100644
--- a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
+++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
@@ -70,6 +70,14 @@
font-size: 2.5em;
line-height: 150%;
}
+ .notification {
+ box-sizing: border-box;
+ width: 100%;
+ padding: 8px 10px;
+ margin: 10px auto 20px;
+ border: 1px solid #666;
+ border-radius: 5px;
+ }
</style>
<iron-location id="url" path="{{_path}}"></iron-location>
<iron-ajax
@@ -111,7 +119,12 @@
<div class="flex layout vertical">
<iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class="flex layout vertical">
<div id="alertsList">
- <div hidden$="[[_haveAlerts]]" id="noAlerts">
+ <div class="list-item" hidden$="[[_hideWebkitNotice]]">
+ <div class="notification">
+ Chromium sheriffs: you now need to handle WebKit bot failures too. <a href="http://www.chromium.org/blink/sheriffing" target="_blank">More information</a>.
+ </div>
+ </div>
+ <div hidden$="[[_haveAlerts]]">
No alerts!
<br>
<img src="/images/jparent-jump.gif" alt="Julie Jumping" title="Julie Jumping">
@@ -230,13 +243,17 @@
type: Boolean,
value: false,
},
+ _fetchingAlerts: {
+ type: Boolean,
+ computed: '_computeFetchingAlerts(_activeRequests)',
+ },
_haveAlerts: {
type: Boolean,
computed: '_computeHaveAlerts(_alerts)',
},
- _fetchingAlerts: {
+ _hideWebkitNotice: {
type: Boolean,
- computed: '_computeFetchingAlerts(_activeRequests)',
+ computed: '_computeHideWebkitNotice(_tree)',
},
logoutUrl: String,
_path: {
@@ -444,6 +461,10 @@
return alerts.length > 0;
},
+ _computeHideWebkitNotice: function(tree) {
+ return tree != "chromium";
+ },
+
////////////////////// Annotations ///////////////////////////
_computeAnnotations: function(annotationsJson) {
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698