Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

Issue 2081383004: SoM: Added notice about chromium webkit failures + documentation links. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Changed logic to just check the tree. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="/bower_components/polymer/polymer.html"> 1 <link rel="import" href="/bower_components/polymer/polymer.html">
2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html"> 2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html">
3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html"> 3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html">
4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html"> 4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html">
5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html"> 5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html">
6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html"> 6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html">
7 <link rel="import" href="/bower_components/iron-location/iron-location.html"> 7 <link rel="import" href="/bower_components/iron-location/iron-location.html">
8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html"> 8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html">
9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html"> 9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html">
10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html"> 10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html">
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 #alertsList { 63 #alertsList {
64 background: white; 64 background: white;
65 border-left: 1px solid #ddd; 65 border-left: 1px solid #ddd;
66 } 66 }
67 #noAlerts { 67 #noAlerts {
68 margin: 1em; 68 margin: 1em;
69 text-align: center; 69 text-align: center;
70 font-size: 2.5em; 70 font-size: 2.5em;
71 line-height: 150%; 71 line-height: 150%;
72 } 72 }
73 .notification {
74 box-sizing: border-box;
75 width: 100%;
76 padding: 8px 10px;
77 margin: 10px auto 20px;
78 border: 1px solid #666;
79 border-radius: 5px;
80 }
73 </style> 81 </style>
74 <iron-location id="url" path="{{_path}}"></iron-location> 82 <iron-location id="url" path="{{_path}}"></iron-location>
75 <iron-ajax 83 <iron-ajax
76 auto 84 auto
77 id="annotations" 85 id="annotations"
78 url="/api/v1/annotations" 86 url="/api/v1/annotations"
79 handle-as="json" 87 handle-as="json"
80 last-error="{{_annotationsJsonError}}" 88 last-error="{{_annotationsJsonError}}"
81 last-response="{{annotationsJson}}" 89 last-response="{{annotationsJson}}"
82 debounce-duration="300"></iron-ajax> 90 debounce-duration="300"></iron-ajax>
(...skipping 21 matching lines...) Expand all
104 <div class="user-name"> 112 <div class="user-name">
105 [[user]] (<a href$="[[logoutUrl]]">Log Out </a>) 113 [[user]] (<a href$="[[logoutUrl]]">Log Out </a>)
106 </div> 114 </div>
107 <paper-icon-button on-tap="_refresh" id="refresh" icon="refresh"></p aper-icon-button> 115 <paper-icon-button on-tap="_refresh" id="refresh" icon="refresh"></p aper-icon-button>
108 </div> 116 </div>
109 <paper-spinner active="[[_fetchingAlerts]]"></paper-spinner> 117 <paper-spinner active="[[_fetchingAlerts]]"></paper-spinner>
110 </paper-toolbar> 118 </paper-toolbar>
111 <div class="flex layout vertical"> 119 <div class="flex layout vertical">
112 <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class= "flex layout vertical"> 120 <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class= "flex layout vertical">
113 <div id="alertsList"> 121 <div id="alertsList">
114 <div hidden$="[[_haveAlerts]]" id="noAlerts"> 122 <div class="list-item" hidden$="[[_hideWebkitNotice]]">
123 <div class="notification">
124 Chromium sheriffs: you now need to handle WebKit bot failures too. <a href="http://www.chromium.org/blink/sheriffing" target="_blank">More inf ormation</a>.
125 </div>
126 </div>
127 <div hidden$="[[_haveAlerts]]">
115 No alerts! 128 No alerts!
116 <br> 129 <br>
117 <img src="/images/jparent-jump.gif" alt="Julie Jumping" title="J ulie Jumping"> 130 <img src="/images/jparent-jump.gif" alt="Julie Jumping" title="J ulie Jumping">
118 </div> 131 </div>
119 <div id="alertsListInner"> 132 <div id="alertsListInner">
120 <template is="dom-repeat" items="[[_alerts]]" as="alert"> 133 <template is="dom-repeat" items="[[_alerts]]" as="alert">
121 <div class="list-item" tabindex$="[[tabIndex]]"> 134 <div class="list-item" tabindex$="[[tabIndex]]">
122 <som-alert-item 135 <som-alert-item
123 alert="{{alert}}" 136 alert="{{alert}}"
124 tree="[[_tree]]" 137 tree="[[_tree]]"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 }, 236 },
224 _annotationPostError: { 237 _annotationPostError: {
225 type: Object, 238 type: Object,
226 value: function() { return {}; }, 239 value: function() { return {}; },
227 }, 240 },
228 _bugModel: Object, 241 _bugModel: Object,
229 _filedBug: { 242 _filedBug: {
230 type: Boolean, 243 type: Boolean,
231 value: false, 244 value: false,
232 }, 245 },
246 _fetchingAlerts: {
247 type: Boolean,
248 computed: '_computeFetchingAlerts(_activeRequests)',
249 },
233 _haveAlerts: { 250 _haveAlerts: {
234 type: Boolean, 251 type: Boolean,
235 computed: '_computeHaveAlerts(_alerts)', 252 computed: '_computeHaveAlerts(_alerts)',
236 }, 253 },
237 _fetchingAlerts: { 254 _hideWebkitNotice: {
238 type: Boolean, 255 type: Boolean,
239 computed: '_computeFetchingAlerts(_activeRequests)', 256 computed: '_computeHideWebkitNotice(_tree)',
240 }, 257 },
241 logoutUrl: String, 258 logoutUrl: String,
242 _path: { 259 _path: {
243 type: String, 260 type: String,
244 }, 261 },
245 _refreshPosition: { 262 _refreshPosition: {
246 type: Number, 263 type: Number,
247 value: function() { return 0; }, 264 value: function() { return 0; },
248 }, 265 },
249 _selectedPage: { 266 _selectedPage: {
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 return allAlerts; 454 return allAlerts;
438 }, 455 },
439 456
440 _computeHaveAlerts: function(alerts) { 457 _computeHaveAlerts: function(alerts) {
441 if (!alerts) { 458 if (!alerts) {
442 return true; 459 return true;
443 } 460 }
444 return alerts.length > 0; 461 return alerts.length > 0;
445 }, 462 },
446 463
464 _computeHideWebkitNotice: function(tree) {
465 return tree != "chromium";
466 },
467
447 ////////////////////// Annotations /////////////////////////// 468 ////////////////////// Annotations ///////////////////////////
448 469
449 _computeAnnotations: function(annotationsJson) { 470 _computeAnnotations: function(annotationsJson) {
450 let annotations = {}; 471 let annotations = {};
451 if (!annotationsJson) { 472 if (!annotationsJson) {
452 return annotations; 473 return annotations;
453 } 474 }
454 annotationsJson.forEach(function(annotation) { 475 annotationsJson.forEach(function(annotation) {
455 annotations[annotation.key] = annotation; 476 annotations[annotation.key] = annotation;
456 }); 477 });
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 } 560 }
540 ).completes.then(() => { 561 ).completes.then(() => {
541 this.$.snoozeTime.value = ''; 562 this.$.snoozeTime.value = '';
542 }); 563 });
543 }, 564 },
544 565
545 }); 566 });
546 })(); 567 })();
547 </script> 568 </script>
548 </dom-module> 569 </dom-module>
OLDNEW
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698