Chromium Code Reviews| Index: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html |
| diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html |
| index bd77b9f95509ee989e32f55f2fe658cf6cf0d81c..072e45013b214140c1b35c565beaf89a7bcbcce9 100644 |
| --- a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html |
| +++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html |
| @@ -68,6 +68,14 @@ |
| background: white; |
| border-left: 1px solid #ddd; |
| } |
| + .notification { |
| + box-sizing: border-box; |
| + width: 100%; |
| + padding: 8px 10px; |
| + margin: 10px auto 20px; |
| + border: 1px solid #666; |
| + border-radius: 5px; |
| + } |
| </style> |
| <iron-location id="url" path="{{_path}}"></iron-location> |
| <iron-ajax |
| @@ -109,7 +117,12 @@ |
| <div class="flex layout vertical"> |
| <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class="flex layout vertical"> |
| <div id="alertsList"> |
| - <div hidden$="[[_haveAlerts]]"> |
| + <div class="list-item" hidden$="[[_hideWebkitNotice]]"> |
| + <div class="notification"> |
| + Chromium sheriffs: you now need to handle WebKit bot failures too. <a href="http://www.chromium.org/blink/sheriffing" target="_blank">More information</a>. |
| + </div> |
| + </div> |
| + <div hidden$="[[_haveAlerts]]"> |
| No alerts! |
| </div> |
| <div id="alertsListInner"> |
| @@ -226,13 +239,17 @@ |
| type: Boolean, |
| value: false, |
| }, |
| + _fetchingAlerts: { |
| + type: Boolean, |
| + computed: '_computeFetchingAlerts(_activeRequests)', |
| + }, |
| _haveAlerts: { |
| type: Boolean, |
| computed: '_computeHaveAlerts(_alerts)', |
| }, |
| - _fetchingAlerts: { |
| + _hideWebkitNotice: { |
| type: Boolean, |
| - computed: '_computeFetchingAlerts(_activeRequests)', |
| + computed: '_computeHideWebkitNotice(_alerts)', |
| }, |
| logoutUrl: String, |
| _path: { |
| @@ -436,6 +453,17 @@ |
| return alerts.length > 0; |
| }, |
| + _computeHideWebkitNotice: function(alerts) { |
|
martiniss
2016/06/23 22:55:07
Why don't we just always show this to chromium she
seanmccullough1
2016/06/23 23:17:30
SGTM
|
| + if (alerts) { |
| + for (var i in alerts) { |
| + if (alerts[i].key.includes("chromium.webkit")) { |
| + return false; |
| + } |
| + } |
| + } |
| + return true; |
| + }, |
| + |
| ////////////////////// Annotations /////////////////////////// |
| _computeAnnotations: function(annotationsJson) { |