Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="/bower_components/polymer/polymer.html"> | 1 <link rel="import" href="/bower_components/polymer/polymer.html"> |
| 2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html"> | 2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html"> |
| 3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html"> | 3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html"> |
| 4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html"> | 4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html"> |
| 5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html"> | 5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html"> |
| 6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html"> | 6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html"> |
| 7 <link rel="import" href="/bower_components/iron-location/iron-location.html"> | 7 <link rel="import" href="/bower_components/iron-location/iron-location.html"> |
| 8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html"> | 8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html"> |
| 9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html"> | 9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html"> |
| 10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html"> | 10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html"> |
| (...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 61 } | 61 } |
| 62 #refresh { | 62 #refresh { |
| 63 width: 25px; | 63 width: 25px; |
| 64 height: 25px; | 64 height: 25px; |
| 65 padding: 0; | 65 padding: 0; |
| 66 } | 66 } |
| 67 #alertsList { | 67 #alertsList { |
| 68 background: white; | 68 background: white; |
| 69 border-left: 1px solid #ddd; | 69 border-left: 1px solid #ddd; |
| 70 } | 70 } |
| 71 .notification { | |
| 72 box-sizing: border-box; | |
| 73 width: 100%; | |
| 74 padding: 8px 10px; | |
| 75 margin: 10px auto 20px; | |
| 76 border: 1px solid #666; | |
| 77 border-radius: 5px; | |
| 78 } | |
| 71 </style> | 79 </style> |
| 72 <iron-location id="url" path="{{_path}}"></iron-location> | 80 <iron-location id="url" path="{{_path}}"></iron-location> |
| 73 <iron-ajax | 81 <iron-ajax |
| 74 auto | 82 auto |
| 75 id="annotations" | 83 id="annotations" |
| 76 url="/api/v1/annotations" | 84 url="/api/v1/annotations" |
| 77 handle-as="json" | 85 handle-as="json" |
| 78 last-error="{{_annotationsJsonError}}" | 86 last-error="{{_annotationsJsonError}}" |
| 79 last-response="{{annotationsJson}}" | 87 last-response="{{annotationsJson}}" |
| 80 debounce-duration="300"></iron-ajax> | 88 debounce-duration="300"></iron-ajax> |
| (...skipping 21 matching lines...) Expand all Loading... | |
| 102 <div class="user-name"> | 110 <div class="user-name"> |
| 103 [[user]] (<a href$="[[logoutUrl]]">Log Out </a>) | 111 [[user]] (<a href$="[[logoutUrl]]">Log Out </a>) |
| 104 </div> | 112 </div> |
| 105 <paper-icon-button on-tap="_refresh" id="refresh" icon="refresh"></p aper-icon-button> | 113 <paper-icon-button on-tap="_refresh" id="refresh" icon="refresh"></p aper-icon-button> |
| 106 </div> | 114 </div> |
| 107 <paper-spinner active="[[_fetchingAlerts]]"></paper-spinner> | 115 <paper-spinner active="[[_fetchingAlerts]]"></paper-spinner> |
| 108 </paper-toolbar> | 116 </paper-toolbar> |
| 109 <div class="flex layout vertical"> | 117 <div class="flex layout vertical"> |
| 110 <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class= "flex layout vertical"> | 118 <iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class= "flex layout vertical"> |
| 111 <div id="alertsList"> | 119 <div id="alertsList"> |
| 112 <div hidden$="[[_haveAlerts]]"> | 120 <div class="list-item" hidden$="[[_hideWebkitNotice]]"> |
| 121 <div class="notification"> | |
| 122 Chromium sheriffs: you now need to handle WebKit bot failures too. <a href="http://www.chromium.org/blink/sheriffing" target="_blank">More inf ormation</a>. | |
| 123 </div> | |
| 124 </div> | |
| 125 <div hidden$="[[_haveAlerts]]"> | |
| 113 No alerts! | 126 No alerts! |
| 114 </div> | 127 </div> |
| 115 <div id="alertsListInner"> | 128 <div id="alertsListInner"> |
| 116 <template is="dom-repeat" items="[[_alerts]]" as="alert"> | 129 <template is="dom-repeat" items="[[_alerts]]" as="alert"> |
| 117 <div class="list-item" tabindex$="[[tabIndex]]"> | 130 <div class="list-item" tabindex$="[[tabIndex]]"> |
| 118 <som-alert-item | 131 <som-alert-item |
| 119 alert="{{alert}}" | 132 alert="{{alert}}" |
| 120 tree="[[_tree]]" | 133 tree="[[_tree]]" |
| 121 selected="[[selected]]" | 134 selected="[[selected]]" |
| 122 annotation="[[_computeAnnotation(annotations, alert)]]" | 135 annotation="[[_computeAnnotation(annotations, alert)]]" |
| (...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 219 }, | 232 }, |
| 220 _annotationPostError: { | 233 _annotationPostError: { |
| 221 type: Object, | 234 type: Object, |
| 222 value: function() { return {}; }, | 235 value: function() { return {}; }, |
| 223 }, | 236 }, |
| 224 _bugModel: Object, | 237 _bugModel: Object, |
| 225 _filedBug: { | 238 _filedBug: { |
| 226 type: Boolean, | 239 type: Boolean, |
| 227 value: false, | 240 value: false, |
| 228 }, | 241 }, |
| 242 _fetchingAlerts: { | |
| 243 type: Boolean, | |
| 244 computed: '_computeFetchingAlerts(_activeRequests)', | |
| 245 }, | |
| 229 _haveAlerts: { | 246 _haveAlerts: { |
| 230 type: Boolean, | 247 type: Boolean, |
| 231 computed: '_computeHaveAlerts(_alerts)', | 248 computed: '_computeHaveAlerts(_alerts)', |
| 232 }, | 249 }, |
| 233 _fetchingAlerts: { | 250 _hideWebkitNotice: { |
| 234 type: Boolean, | 251 type: Boolean, |
| 235 computed: '_computeFetchingAlerts(_activeRequests)', | 252 computed: '_computeHideWebkitNotice(_alerts)', |
| 236 }, | 253 }, |
| 237 logoutUrl: String, | 254 logoutUrl: String, |
| 238 _path: { | 255 _path: { |
| 239 type: String, | 256 type: String, |
| 240 }, | 257 }, |
| 241 _refreshPosition: { | 258 _refreshPosition: { |
| 242 type: Number, | 259 type: Number, |
| 243 value: function() { return 0; }, | 260 value: function() { return 0; }, |
| 244 }, | 261 }, |
| 245 _selectedPage: { | 262 _selectedPage: { |
| (...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 429 return allAlerts; | 446 return allAlerts; |
| 430 }, | 447 }, |
| 431 | 448 |
| 432 _computeHaveAlerts: function(alerts) { | 449 _computeHaveAlerts: function(alerts) { |
| 433 if (!alerts) { | 450 if (!alerts) { |
| 434 return true; | 451 return true; |
| 435 } | 452 } |
| 436 return alerts.length > 0; | 453 return alerts.length > 0; |
| 437 }, | 454 }, |
| 438 | 455 |
| 456 _computeHideWebkitNotice: function(alerts) { | |
|
martiniss
2016/06/23 22:55:07
Why don't we just always show this to chromium she
seanmccullough1
2016/06/23 23:17:30
SGTM
| |
| 457 if (alerts) { | |
| 458 for (var i in alerts) { | |
| 459 if (alerts[i].key.includes("chromium.webkit")) { | |
| 460 return false; | |
| 461 } | |
| 462 } | |
| 463 } | |
| 464 return true; | |
| 465 }, | |
| 466 | |
| 439 ////////////////////// Annotations /////////////////////////// | 467 ////////////////////// Annotations /////////////////////////// |
| 440 | 468 |
| 441 _computeAnnotations: function(annotationsJson) { | 469 _computeAnnotations: function(annotationsJson) { |
| 442 let annotations = {}; | 470 let annotations = {}; |
| 443 if (!annotationsJson) { | 471 if (!annotationsJson) { |
| 444 return annotations; | 472 return annotations; |
| 445 } | 473 } |
| 446 annotationsJson.forEach(function(annotation) { | 474 annotationsJson.forEach(function(annotation) { |
| 447 annotations[annotation.key] = annotation; | 475 annotations[annotation.key] = annotation; |
| 448 }); | 476 }); |
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 531 } | 559 } |
| 532 ).completes.then(() => { | 560 ).completes.then(() => { |
| 533 this.$.snoozeTime.value = ''; | 561 this.$.snoozeTime.value = ''; |
| 534 }); | 562 }); |
| 535 }, | 563 }, |
| 536 | 564 |
| 537 }); | 565 }); |
| 538 })(); | 566 })(); |
| 539 </script> | 567 </script> |
| 540 </dom-module> | 568 </dom-module> |
| OLD | NEW |