Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2081323006: Revert of Rewrite scopes of non-simple default arguments (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Rewrite scopes of non-simple default arguments (patchset #5 id:80001 of https://codereview.chromium.org/2077283004/ ) Reason for revert: Seems to close tree (but it could be an infra issue) Original issue's description: > Rewrite scopes of non-simple default arguments > > Default parameters have additional declaration block scopes inserted > around them when something in the function scope calls eval. This > patch sets the parent scope of the expressions introduced due to > those defaults to the new block scope. > > R=adamk > BUG=chromium:616386 > > Committed: https://crrev.com/0e14baf712955a1993f742647bb2adc293702b80 > Cr-Commit-Position: refs/heads/master@{#37198} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616386 Committed: https://crrev.com/dd50262933d2ac087da32be887a7c18385fd998e Cr-Commit-Position: refs/heads/master@{#37201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M src/parsing/parameter-initializer-rewriter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -21 lines 0 comments Download
D test/mjsunit/regress/regress-616386.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Ehrenberg
Created Revert of Rewrite scopes of non-simple default arguments
4 years, 6 months ago (2016-06-22 19:57:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081323006/1
4 years, 6 months ago (2016-06-22 19:57:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 19:57:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd50262933d2ac087da32be887a7c18385fd998e Cr-Commit-Position: refs/heads/master@{#37201}
4 years, 6 months ago (2016-06-22 19:58:25 UTC) #6
adamk
lgtm, but it looks like this was indeed an infra flake, feel free to reland ...
4 years, 6 months ago (2016-06-22 21:07:08 UTC) #7
Dan Ehrenberg
4 years, 6 months ago (2016-06-22 21:07:34 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2086353003/ by littledan@chromium.org.

The reason for reverting is: Infra issue appears to be over

TBR=adamk@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698