Issue 2081323004: Add GN targets for samples

Issue 2081323004: Add GN targets for samples (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 6 months ago

Reviewers:
Michael Achenbach

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Total comments: 1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	M	BUILD.gn	View		2 chunks	+50 lines, -0 lines	1 comment	Download

Total messages: 7 (2 generated)

Michael Achenbach

lgtm BTW: The v8 CQ doesn't really exercise this code. I've added a bunch of ...

4 years, 6 months ago (2016-06-22 13:09:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081323004/1

4 years, 6 months ago (2016-06-22 13:34:08 UTC) #4

commit-bot: I haz the power

4 years, 6 months ago (2016-06-22 13:37:39 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/344b94560126de662296f89193821db2095aa8ed
Cr-Commit-Position: refs/heads/master@{#37187}