Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: BUILD.gn

Issue 2081323004: Add GN targets for samples (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 4b5b1ef0bc6beefe644747a3c802a90494b7b640..4ca2b81adbaf43f116e8916fb704d1f556911a3c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2055,6 +2055,8 @@ group("gn_all") {
deps = [
":d8",
+ ":v8_hello_world",
+ ":v8_sample_process",
":v8_simple_json_fuzzer",
":v8_simple_parser_fuzzer",
":v8_simple_regexp_fuzzer",
@@ -2143,6 +2145,54 @@ v8_isolate_run("d8") {
isolate = "//src/d8.isolate"
}
+v8_executable("v8_hello_world") {
+ sources = [
+ "samples/hello-world.cc",
+ ]
+
+ configs = [
+ # Note: don't use :internal_config here because this target will get
+ # the :external_config applied to it by virtue of depending on :v8, and
+ # you can't have both applied to the same target.
+ ":internal_config_base",
+ ]
+
+ deps = [
+ ":v8",
+ ":v8_libplatform",
+ "//build/config/sanitizers:deps",
Michael Achenbach 2016/06/22 13:09:53 I lost a bit track about why we need the sanitizer
+ "//build/win:default_exe_manifest",
+ ]
+
+ if (v8_enable_i18n_support) {
+ deps += [ "//third_party/icu" ]
+ }
+}
+
+v8_executable("v8_sample_process") {
+ sources = [
+ "samples/process.cc",
+ ]
+
+ configs = [
+ # Note: don't use :internal_config here because this target will get
+ # the :external_config applied to it by virtue of depending on :v8, and
+ # you can't have both applied to the same target.
+ ":internal_config_base",
+ ]
+
+ deps = [
+ ":v8",
+ ":v8_libplatform",
+ "//build/config/sanitizers:deps",
+ "//build/win:default_exe_manifest",
+ ]
+
+ if (v8_enable_i18n_support) {
+ deps += [ "//third_party/icu" ]
+ }
+}
+
if (want_v8_shell) {
v8_executable("v8_shell") {
sources = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698