Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2081283002: [CacheStorage] Don't call GetUsageAndQuota from a scheduled operation (Closed)

Created:
4 years, 6 months ago by jkarlin
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation Merge into M52. Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create a new Size() scheduled operation, so calling it while in a scheduled operation can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota to just before the operations are scheduled. This means that the size estimate is less accurate, as it's determined potentially well before the operation runs. BUG=620713 Review-Url: https://codereview.chromium.org/2085583002 Cr-Commit-Position: refs/heads/master@{#401001} (cherry picked from commit 36dc82c2b7539b33b63cb6f967feae265625d178) Committed: https://chromium.googlesource.com/chromium/src/+/91b7985947d77fcc337c03248508acf3ed018ce6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -120 lines) Patch
M content/browser/cache_storage/cache_storage_cache.h View 5 chunks +19 lines, -8 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 8 chunks +85 lines, -74 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 3 chunks +3 lines, -38 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
4 years, 6 months ago (2016-06-21 19:13:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91b7985947d77fcc337c03248508acf3ed018ce6.

Powered by Google App Engine
This is Rietveld 408576698