[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.

BUG=620713
Committed: https://crrev.com/36dc82c2b7539b33b63cb6f967feae265625d178
Cr-Commit-Position: refs/heads/master@{#401001}

[jkarlin, 2016-06-20 16:53:29]

Description was changed from

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, resulting in a hung CacheStorage. This CL
moves the calls to GetUsageAndQuota to just before the operations are
scheduled. This means that the size estimate is less accurate, as it's
determined potentially well before the operation runs. But at least
CacheStorage doesn't hang.

BUG=620713
==========

to

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.

But at least CacheStorage doesn't hang.

BUG=620713
==========

[jkarlin, 2016-06-20 16:59:50]

Description was changed from

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.

But at least CacheStorage doesn't hang.

BUG=620713
==========

to

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.


BUG=620713
==========

[jkarlin, 2016-06-21 11:27:24]

jkarlin@chromium.org changed reviewers:
+ jsbell@chromium.org

[jkarlin, 2016-06-21 11:27:35]

jsbell@ PTAL, thanks!

[jsbell, 2016-06-21 15:19:55]

lgtm

https://codereview.chromium.org/2085583002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/2085583002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_cache.cc:360:
base::ThreadTaskRunnerHandle::Get()->PostTask(
Necessary for this CL, or just to ensure consistent ordering?

[jkarlin, 2016-06-21 15:22:54]

Thanks!

https://codereview.chromium.org/2085583002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_cache.cc (right):

https://codereview.chromium.org/2085583002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_cache.cc:360:
base::ThreadTaskRunnerHandle::Get()->PostTask(
On 2016/06/21 15:19:55, jsbell wrote:
> Necessary for this CL, or just to ensure consistent ordering?

Just to return consistently. I need to go over the whole file at some point.

[jkarlin, 2016-06-21 15:23:21]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-06-21 15:23:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085583002/20001

[commit-bot: I haz the power, 2016-06-21 15:53:24]

Description was changed from

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.


BUG=620713
==========

to

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.


BUG=620713
==========

[commit-bot: I haz the power, 2016-06-21 15:53:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 15:55:30]

Description was changed from

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota 
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.


BUG=620713
==========

to

==========
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation

Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.

BUG=620713

Committed: https://crrev.com/36dc82c2b7539b33b63cb6f967feae265625d178
Cr-Commit-Position: refs/heads/master@{#401001}
==========

[commit-bot: I haz the power, 2016-06-21 15:55:31]

Patchset 2 (id:??) landed as
https://crrev.com/36dc82c2b7539b33b63cb6f967feae265625d178
Cr-Commit-Position: refs/heads/master@{#401001}