Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chromeos/dbus/fake_debug_daemon_client.h

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/debug_daemon_client.cc ('k') | chromeos/dbus/fake_debug_daemon_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_debug_daemon_client.h
diff --git a/chromeos/dbus/fake_debug_daemon_client.h b/chromeos/dbus/fake_debug_daemon_client.h
index 01738d15c25258e9232c38f6a6c7b84ec64248a8..1099b5f86873ff767b41a07d372cd891f1d10e60 100644
--- a/chromeos/dbus/fake_debug_daemon_client.h
+++ b/chromeos/dbus/fake_debug_daemon_client.h
@@ -24,8 +24,7 @@ class CHROMEOS_EXPORT FakeDebugDaemonClient : public DebugDaemonClient {
void Init(dbus::Bus* bus) override;
void DumpDebugLogs(bool is_compressed,
- base::File file,
- scoped_refptr<base::TaskRunner> task_runner,
+ int file_descriptor,
const GetDebugLogsCallback& callback) override;
void SetDebugMode(const std::string& subsystem,
const SetDebugModeCallback& callback) override;
@@ -46,7 +45,7 @@ class CHROMEOS_EXPORT FakeDebugDaemonClient : public DebugDaemonClient {
const GetNetworkInterfacesCallback& callback) override;
void GetPerfOutput(base::TimeDelta duration,
const std::vector<std::string>& perf_args,
- dbus::ScopedFileDescriptor file_descriptor,
+ int file_descriptor,
const DBusMethodErrorCallback& error_callback) override;
void GetScrubbedLogs(const GetLogsCallback& callback) override;
void GetScrubbedBigLogs(const GetLogsCallback& callback) override;
« no previous file with comments | « chromeos/dbus/debug_daemon_client.cc ('k') | chromeos/dbus/fake_debug_daemon_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698