Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chromeos/dbus/fake_debug_daemon_client.cc

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_debug_daemon_client.h ('k') | chromeos/dbus/lorgnette_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_debug_daemon_client.cc
diff --git a/chromeos/dbus/fake_debug_daemon_client.cc b/chromeos/dbus/fake_debug_daemon_client.cc
index 3a7d4035fc0ffbfc4b62365611ea1ef5e311ca6c..57680af6dc974a6b4bf2fd662f5f54248b5731fe 100644
--- a/chromeos/dbus/fake_debug_daemon_client.cc
+++ b/chromeos/dbus/fake_debug_daemon_client.cc
@@ -17,7 +17,6 @@
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "chromeos/chromeos_switches.h"
-#include "dbus/file_descriptor.h"
namespace {
@@ -39,8 +38,7 @@ void FakeDebugDaemonClient::Init(dbus::Bus* bus) {}
void FakeDebugDaemonClient::DumpDebugLogs(
bool is_compressed,
- base::File file,
- scoped_refptr<base::TaskRunner> task_runner,
+ int file_descriptor,
const GetDebugLogsCallback& callback) {
callback.Run(true);
}
@@ -111,10 +109,8 @@ void FakeDebugDaemonClient::GetNetworkInterfaces(
void FakeDebugDaemonClient::GetPerfOutput(
base::TimeDelta duration,
const std::vector<std::string>& perf_args,
- dbus::ScopedFileDescriptor file_descriptor,
- const DBusMethodErrorCallback& error_callback) {
- // Nothing to do but close the file descriptor, which its dtor will do.
-}
+ int file_descriptor,
+ const DBusMethodErrorCallback& error_callback) {}
void FakeDebugDaemonClient::GetScrubbedLogs(const GetLogsCallback& callback) {
std::map<std::string, std::string> sample;
« no previous file with comments | « chromeos/dbus/fake_debug_daemon_client.h ('k') | chromeos/dbus/lorgnette_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698