chrome/browser/metrics/perf/perf_output.h - Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/perf/perf_output.h

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/perf/perf_output.h

diff --git a/chrome/browser/metrics/perf/perf_output.h b/chrome/browser/metrics/perf/perf_output.h

index a2cd1e3c2002e03c9ff4c745387dcf63022f5c68..d0f9cde6cb5e3d10eb0adc7ff336c6a11493f311 100644

--- a/chrome/browser/metrics/perf/perf_output.h

+++ b/chrome/browser/metrics/perf/perf_output.h

@@ -14,7 +14,6 @@

#include "base/threading/thread_checker.h"

#include "base/time/time.h"

#include "chromeos/dbus/pipe_reader.h"

-#include "dbus/file_descriptor.h"

// Class for handling getting output from perf over DBus. Manages the

// asynchronous DBus call and retrieving data from quipper over a pipe.

@@ -36,7 +35,6 @@ class PerfOutputCall {

private:

// Internal callbacks.

- void OnFileDescriptorCreated(dbus::ScopedFileDescriptor file_descriptor);

void OnIOComplete();

void OnGetPerfOutputError(const std::string& error_name,

const std::string& error_message);