Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Issue 2081153002: No dbus::FileDescriptor in DebugDaemonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/system_logs/debug_log_writer.cc ('k') | chrome/browser/metrics/perf/perf_output.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
index 1cb54030adea11edc09ba69867213c59b5cac761..47f29ab538d65a5a8733dc03b372e9233e6fe4dc 100644
--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
@@ -32,14 +32,13 @@ class TestDebugDaemonClient : public chromeos::FakeDebugDaemonClient {
~TestDebugDaemonClient() override {}
void DumpDebugLogs(bool is_compressed,
- base::File file,
- scoped_refptr<base::TaskRunner> task_runner,
+ int file_descriptor,
const GetDebugLogsCallback& callback) override {
- base::File* file_param = new base::File(std::move(file));
- task_runner->PostTaskAndReply(
- FROM_HERE,
- base::Bind(
- &GenerateTestLogDumpFile, test_file_, base::Owned(file_param)),
+ // dup() is needed as the file descriptor will be closed on the client side.
+ base::File* file_param = new base::File(dup(file_descriptor));
+ content::BrowserThread::PostBlockingPoolTaskAndReply(
+ FROM_HERE, base::Bind(&GenerateTestLogDumpFile, test_file_,
+ base::Owned(file_param)),
base::Bind(callback, true));
}
« no previous file with comments | « chrome/browser/chromeos/system_logs/debug_log_writer.cc ('k') | chrome/browser/metrics/perf/perf_output.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698