No dbus::FileDescriptor in DebugDaemonClient

chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
index 1cb54030adea11edc09ba69867213c59b5cac761..46e8dd265b812621d6307b3a4432956c0343395a 100644
--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
@@ -32,14 +32,12 @@ class TestDebugDaemonClient : public chromeos::FakeDebugDaemonClient {
   ~TestDebugDaemonClient() override {}
 
   void DumpDebugLogs(bool is_compressed,
-                     base::File file,
-                     scoped_refptr<base::TaskRunner> task_runner,
+                     int file_descriptor,
                      const GetDebugLogsCallback& callback) override {
-    base::File* file_param = new base::File(std::move(file));
-    task_runner->PostTaskAndReply(
-        FROM_HERE,
-        base::Bind(
-            &GenerateTestLogDumpFile, test_file_, base::Owned(file_param)),
+    base::File* file_param = new base::File(dup(file_descriptor));

[satorux1, 2016/08/23 07:02:02]

I think it's not so obvious why dup() is needed here, maybe add something like:

// dup() is needed as the file descriptor will be closed on the client side.

[hashimoto, 2016/08/23 07:41:27]

Done.

+    content::BrowserThread::PostBlockingPoolTaskAndReply(
+        FROM_HERE, base::Bind(&GenerateTestLogDumpFile, test_file_,
+                              base::Owned(file_param)),
         base::Bind(callback, true));
   }