No dbus::FileDescriptor in DebugDaemonClient

chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "chrome/browser/extensions/extension_apitest.h"
@@ skipping 14 matching lines @@
 namespace {
 
 class TestDebugDaemonClient : public chromeos::FakeDebugDaemonClient {
  public:
   explicit TestDebugDaemonClient(const base::FilePath& test_file)
       : test_file_(test_file) {}
 
   ~TestDebugDaemonClient() override {}
 
   void DumpDebugLogs(bool is_compressed,
-                     base::File file,
-                     scoped_refptr<base::TaskRunner> task_runner,
+                     int file_descriptor,
                      const GetDebugLogsCallback& callback) override {
-    base::File* file_param = new base::File(std::move(file));
-    task_runner->PostTaskAndReply(
-        FROM_HERE,
-        base::Bind(
-            &GenerateTestLogDumpFile, test_file_, base::Owned(file_param)),
+    base::File* file_param = new base::File(dup(file_descriptor));

[satorux1, 2016/08/23 07:02:02]

I think it's not so obvious why dup() is needed here, maybe add something like:

// dup() is needed as the file descriptor will be closed on the client side.

[hashimoto, 2016/08/23 07:41:27]

Done.

+    content::BrowserThread::PostBlockingPoolTaskAndReply(
+        FROM_HERE, base::Bind(&GenerateTestLogDumpFile, test_file_,
+                              base::Owned(file_param)),
         base::Bind(callback, true));
   }
 
   static void GenerateTestLogDumpFile(const base::FilePath& test_tar_file,
                                       base::File* file) {
     std::string test_file_content;
     EXPECT_TRUE(base::ReadFileToString(test_tar_file, &test_file_content))
         << "Cannot read content of file " << test_tar_file.value();
     const int data_size = static_cast<int>(test_file_content.size());
     EXPECT_EQ(data_size, file->Write(0, test_file_content.data(), data_size));
@@ skipping 38 matching lines @@
   // Setup dummy HTTP server.
   host_resolver()->AddRule("www.test.com", "127.0.0.1");
   ASSERT_TRUE(StartEmbeddedTestServer());
   embedded_test_server()->RegisterRequestHandler(
       base::Bind(&LogPrivateApiTest::HandleRequest, base::Unretained(this)));
 
   ASSERT_TRUE(RunExtensionTest("log_private/dump_logs"));
 }
 
 }  // namespace extensions