third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py - Issue 2081113005: Removed command to add display:none to class="instructions" elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

Issue 2081113005: Removed command to add display:none to class="instructions" elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

index 0adfd832ab119b3f7e39777e3ae962690260eb48..04306824f9b50d747124df785ed65e9e8a00b560 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

@@ -211,36 +211,6 @@ CONTENT OF TEST

self.verify_conversion_happened(converted)

self.verify_prefixed_properties(converted, test_content[0])

- def test_hides_all_instructions_for_manual_testers(self):

- test_html = """<body>

-<h1 class="instructions">Hello manual tester!</h1>

-<p class="instructions some_other_class">This is how you run this test.</p>

-<p style="willbeoverwritten" class="instructions">...</p>

-<doesntmatterwhichtagitis class="some_other_class instructions">...</p>

-<p>Legit content may contain the instructions string</p>

-</body>

-"""

- expected_test_html = """<body>

-<h1 class="instructions" style="display:none">Hello manual tester!</h1>

-<p class="instructions some_other_class" style="display:none">This is how you run this test.</p>

-<p class="instructions" style="display:none">...</p>

-<doesntmatterwhichtagitis class="some_other_class instructions" style="display:none">...</p>

-<p>Legit content may contain the instructions string</p>

-</body>

-"""

- converter = _W3CTestConverter(DUMMY_PATH, DUMMY_FILENAME, None)

- oc = OutputCapture()

- oc.capture_output()

- try:

- converter.feed(test_html)

- converter.close()

- converted = converter.output()

- finally:

- oc.restore_output()

- self.assertEqual(converted[1], expected_test_html)

def test_convert_attributes_if_needed(self):

"""Tests convert_attributes_if_needed() using a reference file that has some relative src paths."""

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py ('k') | no next file » | no next file with comments »