third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py - Issue 2081113005: Removed command to add display:none to class="instructions" elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

Issue 2081113005: Removed command to add display:none to class="instructions" elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

index 061595e0f7e97700583dba80f799d297329b3bcf..356b601f591ea20694d0c9729538ab978d7572aa 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

@@ -168,10 +168,6 @@ class _W3CTestConverter(HTMLParser):

if attr_name == 'style':

new_style = self.convert_style_data(attr_value)

converted = re.sub(re.escape(attr_value), new_style, converted)

- if attr_name == 'class' and 'instructions' in attr_value:

- # Always hide instructions, they're for manual testers.

- converted = re.sub(r' style=".*?"', '', converted)

- converted = re.sub(r'\>', ' style="display:none">', converted)

src_tags = ('script', 'img', 'style', 'frame', 'iframe', 'input', 'layer', 'textarea', 'video', 'audio')

if tag in src_tags and self.reference_support_info is not None and self.reference_support_info != {}:

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py » ('j') | no next file with comments »