Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2081093002: Cleanup: Remove video constraint names (Closed)

Created:
4 years, 6 months ago by hta - Chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove video constraint names This CL removes now-unused video constraint names from the content/ layer. No functional changes. BUG=537590 Committed: https://crrev.com/785daecf4b97886fbde857e6a1b4da4514d8f0e8 Cr-Commit-Position: refs/heads/master@{#400920}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -88 lines) Patch
M content/common/media/media_stream_options.h View 1 chunk +3 lines, -14 lines 0 comments Download
M content/common/media/media_stream_options.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_source.h View 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hta - Chromium
Just tidying the barn.
4 years, 6 months ago (2016-06-21 07:12:40 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2081093002/diff/1/content/renderer/media/media_stream_audio_processor_options.cc File content/renderer/media/media_stream_audio_processor_options.cc (right): https://codereview.chromium.org/2081093002/diff/1/content/renderer/media/media_stream_audio_processor_options.cc#newcode51 content/renderer/media/media_stream_audio_processor_options.cc:51: // Controls whether the hotword audio stream is ...
4 years, 6 months ago (2016-06-21 07:17:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081093002/20001
4 years, 6 months ago (2016-06-21 07:36:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 08:21:16 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/785daecf4b97886fbde857e6a1b4da4514d8f0e8 Cr-Commit-Position: refs/heads/master@{#400920}
4 years, 6 months ago (2016-06-21 08:22:44 UTC) #9
hta - Chromium
4 years, 6 months ago (2016-06-23 15:51:17 UTC) #10
Message was sent while issue was closed. 
Forgot to send the last draft before submission.

https://codereview.chromium.org/2081093002/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_audio_processor_options.cc (right):

https://codereview.chromium.org/2081093002/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_audio_processor_options.cc:51: // Controls
whether the hotword audio stream is used on platforms that support
On 2016/06/21 07:17:41, tommi-chrömium wrote:
> nit: "used on supported platforms."

Done.

Powered by Google App Engine
This is Rietveld 408576698