Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2080973002: [Mac][Material Design] Fix problem with tab close button redraw. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix problem with tab close button redraw. With a theme installed the close button's "x" can have a different color for the tab active and inactive states. This cl forces the close button to redraw on tab state change so that it displays the "x" in the correct color. R=tapted@chromium.org BUG=616008 Review-Url: https://codereview.chromium.org/2073523002 Cr-Commit-Position: refs/heads/master@{#400162} (cherry picked from commit 29bd2eed90a5c548ce737aa09225952bfab22461) Committed: https://chromium.googlesource.com/chromium/src/+/ab1fa8cfc752cc3f21a6af02b5f5a373f36f02b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
4 years, 6 months ago (2016-06-20 21:29:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab1fa8cfc752cc3f21a6af02b5f5a373f36f02b2.

Powered by Google App Engine
This is Rietveld 408576698