Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2073523002: [Mac][Material Design] Fix problem with tab close button redraw. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix problem with tab close button redraw. With a theme installed the close button's "x" can have a different color for the tab active and inactive states. This cl forces the close button to redraw on tab state change so that it displays the "x" in the correct color. R=tapted@chromium.org BUG=616008 Committed: https://crrev.com/29bd2eed90a5c548ce737aa09225952bfab22461 Cr-Commit-Position: refs/heads/master@{#400162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 6 months ago (2016-06-15 21:19:30 UTC) #1
tapted
lgtm
4 years, 6 months ago (2016-06-16 05:29:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073523002/1
4 years, 6 months ago (2016-06-16 15:03:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 15:40:35 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:43:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29bd2eed90a5c548ce737aa09225952bfab22461
Cr-Commit-Position: refs/heads/master@{#400162}

Powered by Google App Engine
This is Rietveld 408576698