Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2080793003: Revert of ServiceWorker: Bypass SW when the script doesn't have fetch handler (Closed)

Created:
4 years, 6 months ago by shimazu
Modified:
4 years, 6 months ago
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Bypass SW when the script doesn't have fetch handler (patchset #5 id:80001 of https://codereview.chromium.org/2019613003/ ) Reason for revert: See: http://crbug.com/621788 Original issue's description: > ServiceWorker: Bypass SW when the script doesn't have fetch handler > > When the script doesn't have a fetch handler, a request > will immediately go to the network after passed to SW in current implementation. > However, if SW is down, this procedure will wait for waking SW up though SW > doesn't have fetch handler. This patch enables the request to directly go to > network bypassing SW in this situation. > > BUG=605844 > TEST=/out/Release/content_unittest --gtest_filter="ServiceWorkerControlleeRequestHandlerTest.FallbackWithNoFetchHandler" > > Committed: https://crrev.com/8a5ede2ab476d57dbce99422d89333b71cd7dcab > Cr-Commit-Position: refs/heads/master@{#396787} TBR=falken@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605844 Committed: https://crrev.com/c367daaa701cf3e439ab3f75108a2fdd2c00342b Cr-Commit-Position: refs/heads/master@{#400928}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 4 chunks +4 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 5 chunks +0 lines, -37 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shimazu
Created Revert of ServiceWorker: Bypass SW when the script doesn't have fetch handler
4 years, 6 months ago (2016-06-21 06:55:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080793003/1
4 years, 6 months ago (2016-06-21 06:55:55 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23847) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-21 06:57:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080793003/100001
4 years, 6 months ago (2016-06-21 07:50:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 6 months ago (2016-06-21 09:15:01 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 09:16:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c367daaa701cf3e439ab3f75108a2fdd2c00342b
Cr-Commit-Position: refs/heads/master@{#400928}

Powered by Google App Engine
This is Rietveld 408576698