Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2080733002: Revert of Make the notification builder more XPC friendly (Closed)

Created:
4 years, 6 months ago by vasilii
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-notifications_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make the notification builder more XPC friendly (patchset #6 id:100001 of https://codereview.chromium.org/2053613002/ ) Reason for revert: Broke compilation on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/16903/steps/compile/logs/stdio ../../chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:11:10: fatal error: 'chrome/grit/generated_resources.h' file not found #include "chrome/grit/generated_resources.h" Original issue's description: > Make the notification builder more XPC friendly > > Move it to ui/cocoa/notifications where the xpc service will eventually live. > Make it a static library so it can be linked by both the app and the XPC. > Make sure the build operation only uses information from the underlying > dictionary. > > BUG=571056 > > Committed: https://crrev.com/aafb03bf0df164a2fb86db117ae6053e9578c437 > Cr-Commit-Position: refs/heads/master@{#400672} TBR=jochen@chromium.org,peter@chromium.org,rsesek@chromium.org,miguelg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=571056 Committed: https://crrev.com/9753d56a309ead6e186dc28dcd821f63c1c3e458 Cr-Commit-Position: refs/heads/master@{#400679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -507 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
A chrome/browser/notifications/notification_builder_mac.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_builder_mac.mm View 1 chunk +214 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_builder_mac_unittest.mm View 1 chunk +152 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
D chrome/browser/ui/cocoa/notifications/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/notification_builder_mac.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm View 1 chunk +0 lines, -231 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/notification_common.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
vasilii
Created Revert of Make the notification builder more XPC friendly
4 years, 6 months ago (2016-06-20 14:54:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080733002/1
4 years, 6 months ago (2016-06-20 14:54:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 14:59:00 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:00:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9753d56a309ead6e186dc28dcd821f63c1c3e458
Cr-Commit-Position: refs/heads/master@{#400679}

Powered by Google App Engine
This is Rietveld 408576698