Deprecate 'js-test.js' with an overridable pre-upload check.

Deprecate 'js-test.js' with an overridable pre-upload check.

Throw a presubmit warning if a line containing 'resources/js-test.js'
appears inside a patch's modifications to //LayoutTests. Point developers
to 'testharness.js' instead.

BUG=621108
R=pdr@chromium.org

Committed: https://crrev.com/ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b
Cr-Commit-Position: refs/heads/master@{#401409}

[Mike West, 2016-06-21 14:39:42]

WDYT, pdr@?

[pdr., 2016-06-21 16:00:58]

Super cool, thank you!

LGTM

https://codereview.chromium.org/2080663004/diff/1/third_party/WebKit/PRESUBMI...
File third_party/WebKit/PRESUBMIT.py (right):

https://codereview.chromium.org/2080663004/diff/1/third_party/WebKit/PRESUBMI...
third_party/WebKit/PRESUBMIT.py:197:
white_list=[r'third_party/WebKit/LayoutTests/.*\.(html|js)$'])
Nit: can you add svg here too?

[Mike West, 2016-06-22 07:05:56]

On 2016/06/21 at 16:00:58, pdr wrote:
> Super cool, thank you!
> 
> LGTM
> 
>
https://codereview.chromium.org/2080663004/diff/1/third_party/WebKit/PRESUBMI...
> File third_party/WebKit/PRESUBMIT.py (right):
> 
>
https://codereview.chromium.org/2080663004/diff/1/third_party/WebKit/PRESUBMI...
> third_party/WebKit/PRESUBMIT.py:197:
white_list=[r'third_party/WebKit/LayoutTests/.*\.(html|js)$'])
> Nit: can you add svg here too?

Also .php and .pl. Thanks for making me take another look!

[Mike West, 2016-06-22 07:06:01]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-06-22 07:06:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2080663004/#ps20001
(title: "pdr@")

[commit-bot: I haz the power, 2016-06-22 07:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080663004/20001

[commit-bot: I haz the power, 2016-06-22 07:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 07:13:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2016-06-22 08:40:24]

mkwst@chromium.org changed reviewers:
+ dpranke@chromium.org

[Mike West, 2016-06-22 08:40:24]

dpranke@: Would you mind taking a quick look at this PRESUBMIT addition?

[Dirk Pranke, 2016-06-22 16:15:01]

lgtm

[Mike West, 2016-06-22 18:25:56]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080663004/20001

[commit-bot: I haz the power, 2016-06-22 21:23:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-22 21:28:23]

Description was changed from

==========
Deprecate 'js-test.js' with an overridable pre-upload check.

Throw a presubmit warning if a line containing 'resources/js-test.js'
appears inside a patch's modifications to //LayoutTests. Point developers
to 'testharness.js' instead.

BUG=621108
R=pdr@chromium.org
==========

to

==========
Deprecate 'js-test.js' with an overridable pre-upload check.

Throw a presubmit warning if a line containing 'resources/js-test.js'
appears inside a patch's modifications to //LayoutTests. Point developers
to 'testharness.js' instead.

BUG=621108
R=pdr@chromium.org

Committed: https://crrev.com/ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b
Cr-Commit-Position: refs/heads/master@{#401409}
==========

[commit-bot: I haz the power, 2016-06-22 21:28:24]

Patchset 2 (id:??) landed as
https://crrev.com/ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b
Cr-Commit-Position: refs/heads/master@{#401409}