Deprecate 'js-test.js' with an overridable pre-upload check.

third_party/WebKit/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 170 matching lines @@
         input_api, None)
     errors = ['  * %s' % violation for violation in errors]
     if errors:
         return [output_api.PresubmitPromptOrNotify(
                     'printf debugging is best debugging! That said, it might '
                     'be a good idea to drop the following occurances from '
                     'your patch before uploading:\n%s' % '\n'.join(errors))]
     return []
 
 
+def _CheckForJSTest(input_api, output_api):
+    """'js-test.js' is the past, 'testharness.js' is our glorious future"""
+    jstest_re = input_api.re.compile(r'resources/js-test.js')
+
+    def source_file_filter(path):
+        return input_api.FilterSourceFile(path,
+                                          white_list=[r'third_party/WebKit/LayoutTests/.*\.(html|js|php|pl|svg)$'])
+
+    errors = input_api.canned_checks._FindNewViolationsOfRule(
+        lambda _, x: not jstest_re.search(x), input_api, source_file_filter)
+    errors = ['  * %s' % violation for violation in errors]
+    if errors:
+        return [output_api.PresubmitPromptOrNotify(
+            '"resources/js-test.js" is deprecated; please write new layout '
+            'tests using the assertions in "resources/testharness.js" '
+            'instead, as these can be more easily upstreamed to Web Platform '
+            'Tests for cross-vendor compatibility testing. If you\'re not '
+            'already familiar with this framework, a tutorial is available at '
+            'https://darobin.github.io/test-harness-tutorial/docs/using-testharness.html.'
+            'with the new framework.\n\n%s' % '\n'.join(errors))]
+    return []
+
 def _CheckForFailInFile(input_api, f):
     pattern = input_api.re.compile('^FAIL')
     errors = []
     for line_num, line in f.ChangedContents():
         if pattern.match(line):
             errors.append('    %s:%d %s' % (f.LocalPath(), line_num, line))
     return errors
 
 
 def _CheckFilePermissions(input_api, output_api):
@@ skipping 75 matching lines @@
         if errors:
             result += [output_api.PresubmitError('Do not use Chromium class {} inside Blink core:\n{}'.format(class_name, '\n'.join(errors)))]
     return result
 
 
 def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(_CheckStyle(input_api, output_api))
     results.extend(_CheckForPrintfDebugging(input_api, output_api))
+    results.extend(_CheckForJSTest(input_api, output_api))
     results.extend(_CheckForInvalidPreferenceError(input_api, output_api))
     results.extend(_CheckForForbiddenNamespace(input_api, output_api))
     return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(input_api.canned_checks.CheckTreeIsOpen(
         input_api, output_api,
@@ skipping 21 matching lines @@
     for master in masters:
         try_config.setdefault(master, {})
         for builder in masters[master]:
             # Do not trigger presubmit builders, since they're likely to fail
             # (e.g. OWNERS checks before finished code review), and we're
             # running local presubmit anyway.
             if 'presubmit' not in builder:
                 try_config[master][builder] = ['defaulttests']
 
     return try_config