Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208053003: Fix HeapSnapshotView leaks (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, dgozman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Fix HeapSnapshotView leaks HeapSnapshotView should be unsubscribed from events it has been subscribed to, otherwise it will leak when corresponding profile is removed. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169738

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M Source/devtools/front_end/HeapSnapshotView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/SplitView.js View 1 3 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
yurys
6 years, 9 months ago (2014-03-21 11:38:21 UTC) #1
alph
lgtm
6 years, 9 months ago (2014-03-21 11:40:30 UTC) #2
dgozman
lgtm
6 years, 9 months ago (2014-03-21 11:45:48 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 11:49:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/208053003/20001
6 years, 9 months ago (2014-03-21 11:49:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 11:51:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 11:51:08 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 11:56:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/208053003/20001
6 years, 9 months ago (2014-03-21 11:56:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 12:01:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-21 12:01:21 UTC) #11
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 12:01:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/208053003/20001
6 years, 9 months ago (2014-03-21 12:02:00 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 12:44:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 12:44:50 UTC) #15
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 12:57:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/208053003/20001
6 years, 9 months ago (2014-03-21 12:57:32 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 13:29:52 UTC) #18
Message was sent while issue was closed. 
Change committed as 169738

Powered by Google App Engine
This is Rietveld 408576698