Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 208053003: Fix HeapSnapshotView leaks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/SplitView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/HeapSnapshotView.js b/Source/devtools/front_end/HeapSnapshotView.js
index 0c0f2f09700093a77088616bf73c3e334040f77d..dabc32e63cbefd0daf5b83215f3f5831e41ff44b 100644
--- a/Source/devtools/front_end/HeapSnapshotView.js
+++ b/Source/devtools/front_end/HeapSnapshotView.js
@@ -39,7 +39,7 @@ WebInspector.HeapSnapshotView = function(profile)
this.element.classList.add("heap-snapshot-view");
- profile.profileType().addEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, this._onReceivSnapshot, this);
+ profile.profileType().addEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, this._onReceiveSnapshot, this);
profile.profileType().addEventListener(WebInspector.ProfileType.Events.RemoveProfileHeader, this._onProfileHeaderRemoved, this);
if (profile._profileType.id === WebInspector.TrackingHeapSnapshotProfileType.TypeId) {
@@ -977,7 +977,7 @@ WebInspector.HeapSnapshotView.prototype = {
/**
* @param {!WebInspector.Event} event
*/
- _onReceivSnapshot: function(event)
+ _onReceiveSnapshot: function(event)
{
this._updateControls();
},
@@ -990,7 +990,7 @@ WebInspector.HeapSnapshotView.prototype = {
var profile = event.data;
if (this._profile === profile) {
this.detach();
- this._profile.profileType().removeEventListener(WebInspector.ProfileType.Events.AddProfileHeader, this._onReceivSnapshot, this);
+ this._profile.profileType().removeEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, this._onReceiveSnapshot, this);
this._profile.profileType().removeEventListener(WebInspector.ProfileType.Events.RemoveProfileHeader, this._onProfileHeaderRemoved, this);
} else {
this._updateControls();
« no previous file with comments | « no previous file | Source/devtools/front_end/SplitView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698