Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2080463002: DatabaseTracker: Use 'raw' string as key for origin (Closed)

Created:
4 years, 6 months ago by michaeln
Modified:
4 years, 6 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org Review-Url: https://codereview.chromium.org/2050803005 Cr-Commit-Position: refs/heads/master@{#399743} (cherry picked from commit 1667e9b86e2ede1e6267db73445478b447cca2e8) Committed: https://chromium.googlesource.com/chromium/src/+/09a5bbb16c83ffad3ec63a6e272367428c190a2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
michaeln
4 years, 6 months ago (2016-06-17 22:11:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09a5bbb16c83ffad3ec63a6e272367428c190a2a.

Powered by Google App Engine
This is Rietveld 408576698