Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2050803005:
DatabaseTracker: Use 'raw' string as key for origin (Closed)
DescriptionDatabaseTracker: Use 'raw' string as key for origin
Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and
a serialization was used as the key in maps. This was changed to take
SecurityOrigins instead and the serialization via toString(). This
introduced additional special cases e.g. "null" for file:// origins in
some cases, leading to mismatches between setting and lookup in the
map depending on when the SecurityOrigin was minted. To fix, use
toRawString() within the DatabaseTracker which matches the old behavior.
Similarly, use toRawString() when serializing an origin for posting
across threads.
BUG=618381
R=michaeln@chromium.org
Committed: https://crrev.com/1667e9b86e2ede1e6267db73445478b447cca2e8
Cr-Commit-Position: refs/heads/master@{#399743}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the QuotaTracker API took DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() which matches the old behavior without special cases. BUG=618381 R=michaeln@chromium.org ========== to ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() which matches the old behavior without special cases. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ==========
michaeln@ - please take a look? This is very similar to https://codereview.chromium.org/1914763002 - unfortunately not as easily testable.
Description was changed from ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() which matches the old behavior without special cases. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ========== to ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ==========
lgtm, thanx for dealing with the fallout
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050803005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050803005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050803005/1
Message was sent while issue was closed.
Description was changed from ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ========== to ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org ========== to ========== DatabaseTracker: Use 'raw' string as key for origin Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() within the DatabaseTracker which matches the old behavior. Similarly, use toRawString() when serializing an origin for posting across threads. BUG=618381 R=michaeln@chromium.org Committed: https://crrev.com/1667e9b86e2ede1e6267db73445478b447cca2e8 Cr-Commit-Position: refs/heads/master@{#399743} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1667e9b86e2ede1e6267db73445478b447cca2e8 Cr-Commit-Position: refs/heads/master@{#399743} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
