chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java - Issue 2080173006: customtabs: Allowing prerendering on cellular also disables throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java

Issue 2080173006: customtabs: Allowing prerendering on cellular also disables throttling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java

index a855517a82832c5d85e12975470bb79c2b6cbfae..7a43b63a2aeb0235b9492faa16f418a2273a41b9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java

@@ -178,6 +178,14 @@ class RequestThrottler {

.apply();

}

+ /** Bans from prerendering. Used for testing. */

+ void ban() {

+ mScore = -1;

+ SharedPreferences.Editor editor = mSharedPreferences.edit();

+ updateBan(editor);

+ editor.apply();

+ }

/**

* Loads the SharedPreferences in the background.