Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2080133002: Revert of Integers can now be passed as uniforms (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Integers can now be passed as uniforms (patchset #1 id:1 of https://codereview.chromium.org/2076143003/ ) Reason for revert: Compile failures on Vulkan platforms (eg https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan) Original issue's description: > Integers can now be passed as uniforms; needed for passing color count to fragment shader > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003 > > Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198 TBR=tomhudson@google.com,bsalomon@google.com,fmenozzi@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/452ba88066b51931696fc3d0a2a1c0f8809a4143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/gpu/gl/GrGLProgramDataManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Integers can now be passed as uniforms
4 years, 6 months ago (2016-06-20 00:48:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080133002/1
4 years, 6 months ago (2016-06-20 00:48:10 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 01:05:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/452ba88066b51931696fc3d0a2a1c0f8809a4143

Powered by Google App Engine
This is Rietveld 408576698