Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2080113002: [turbofan] Introduce CheckUnless. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CheckUnless. Similarly to CheckIf, CheckUnless is a deoptimization without a specific frame state. A frame state is assigned during effect-control linearization (and CheckUnless is turned into DeoptimizeUnless). At the moment, the new operator is only used at one place in native context specialization, but we should use it everywhere. The advantage of CHeckUnless is that it avoids non-truncating uses of values by frame states. This particular change is aimed at Octane's crypto, where this enables to turn one NumberMultiply into Int32Mul, and thus improve the score by more than 10% (it also needs minus zero truncation and typing to be improved, but those CLs are already in flight). BUG=v8:4470 R=bmeurer@chromium.org Committed: https://crrev.com/85fde59d538e0dcaf461108086c2f7cf904f567a Cr-Commit-Position: refs/heads/master@{#37085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-19 19:05:45 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-20 03:44:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080113002/1
4 years, 6 months ago (2016-06-20 03:44:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 03:46:40 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85fde59d538e0dcaf461108086c2f7cf904f567a Cr-Commit-Position: refs/heads/master@{#37085}
4 years, 6 months ago (2016-06-20 03:48:31 UTC) #10
Michael Achenbach
4 years, 6 months ago (2016-06-20 07:40:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2078333002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert: Seems to lead to
devtools crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/5259.

Powered by Google App Engine
This is Rietveld 408576698