[stubs] Implementing CodeStubAssembler::GetOwnProperty().

[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y

Committed: https://crrev.com/23332fe8296b48e66775e352de4759494553c12c
Cr-Commit-Position: refs/heads/master@{#37291}

[Igor Sheludko, 2016-06-17 16:17:43]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 16:17:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079823002/1

[commit-bot: I haz the power, 2016-06-17 16:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 16:22:37]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2016-06-20 07:07:58]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-06-20 07:48:18]

Patchset #2 (id:40001) has been deleted

[Igor Sheludko, 2016-06-20 07:48:24]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-20 07:49:17]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 07:49:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079823002/60001

[commit-bot: I haz the power, 2016-06-20 08:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 08:22:17]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-21 12:43:23]

Patchset #2 (id:80001) has been deleted

[Igor Sheludko, 2016-06-21 12:43:27]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-06-21 12:48:20]

Description was changed from

==========
WIP: Implementing GetPropertyStub

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a prerequisite for GetPropertyStub.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 12:48:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 12:48:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079823002/100001

[Igor Sheludko, 2016-06-21 12:50:02]

Description was changed from

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a prerequisite for GetPropertyStub.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 12:51:02]

Description was changed from

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast, slow
and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 12:51:21]

Description was changed from

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast, slow
and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 12:52:09]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-06-21 12:52:10]

PTAL

[commit-bot: I haz the power, 2016-06-21 13:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 13:17:00]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-06-23 12:34:55]

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:1719: GotoIf(Word32NotEqual(Word32And(bit_field,
mask), Int32Constant(0)),
This shouldn't be possible if we check LAST_SPECIAL_RECEIVER_TYPE previously. If
so, turn into Assert?

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:1953: GotoIf(WordEqual(value, TheHoleConstant()),
if_deleted);
This should already have been handled in TryLookupProperty. That one should
probably return the property cell directly rather than the dictionary backing
store. That avoids duplicate access.

[Igor Sheludko, 2016-06-27 09:29:40]

Patchset #3 (id:140001) has been deleted

[Igor Sheludko, 2016-06-27 09:29:50]

Patchset #2 (id:120001) has been deleted

[Igor Sheludko, 2016-06-27 09:32:17]

PTAL again

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:1719: GotoIf(Word32NotEqual(Word32And(bit_field,
mask), Int32Constant(0)),
On 2016/06/23 12:34:54, Toon Verwaest wrote:
> This shouldn't be possible if we check LAST_SPECIAL_RECEIVER_TYPE previously.
If
> so, turn into Assert?

Done.

https://codereview.chromium.org/2079823002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:1953: GotoIf(WordEqual(value, TheHoleConstant()),
if_deleted);
On 2016/06/23 12:34:54, Toon Verwaest wrote:
> This should already have been handled in TryLookupProperty. That one should
> probably return the property cell directly rather than the dictionary backing
> store. That avoids duplicate access.

Currently it's the caller responsibility to do a hole check. There's no
duplicate access in this case. 
Otherwise I would have to return both property cell and the value from
TryLookupProperty. TryLookpuProperty is a building block anyway, so I think it's
fine to leave it as is.

[Igor Sheludko, 2016-06-27 09:54:20]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 09:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 10:00:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:00:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)

[Igor Sheludko, 2016-06-27 10:15:30]

Patchset #2 (id:160001) has been deleted

[Igor Sheludko, 2016-06-27 10:15:41]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 10:15:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 10:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:40:58]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-06-27 12:13:26]

lgtm

[Igor Sheludko, 2016-06-27 12:17:34]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-27 12:17:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 12:27:02]

Description was changed from

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

[commit-bot: I haz the power, 2016-06-27 12:27:04]

Committed patchset #2 (id:180001)

[commit-bot: I haz the power, 2016-06-27 12:27:48]

Description was changed from

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] Implementing CodeStubAssembler::GetOwnProperty().

This is a building block for GetPropertyStub. It supports querying fast,
slow and global objects without native accessors and interceptors.

BUG=v8:4911
LOG=Y

Committed: https://crrev.com/23332fe8296b48e66775e352de4759494553c12c
Cr-Commit-Position: refs/heads/master@{#37291}
==========

[commit-bot: I haz the power, 2016-06-27 12:27:49]

Patchset 2 (id:??) landed as
https://crrev.com/23332fe8296b48e66775e352de4759494553c12c
Cr-Commit-Position: refs/heads/master@{#37291}