Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/objects-inl.h

Issue 2079823002: [stubs] Implementing CodeStubAssembler::GetOwnProperty(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixing TryHasOwnProperty and addressing comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index fac56495a0048ab66f4678fad43bce600df9050f..91b7246f21ca46aa7f0cf61e7d834385d0738c4a 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -7372,9 +7372,9 @@ void BaseDictionaryShape<Key>::SetEntry(Dictionary* dict, int entry,
int index = dict->EntryToIndex(entry);
DisallowHeapAllocation no_gc;
WriteBarrierMode mode = dict->GetWriteBarrierMode(no_gc);
- dict->set(index, *key, mode);
- dict->set(index + 1, *value, mode);
- dict->set(index + 2, details.AsSmi());
+ dict->set(index + Dictionary::kEntryKeyIndex, *key, mode);
+ dict->set(index + Dictionary::kEntryValueIndex, *value, mode);
+ dict->set(index + Dictionary::kEntryDetailsIndex, details.AsSmi());
}
@@ -7388,8 +7388,8 @@ void GlobalDictionaryShape::SetEntry(Dictionary* dict, int entry,
int index = dict->EntryToIndex(entry);
DisallowHeapAllocation no_gc;
WriteBarrierMode mode = dict->GetWriteBarrierMode(no_gc);
- dict->set(index, *key, mode);
- dict->set(index + 1, *value, mode);
+ dict->set(index + Dictionary::kEntryKeyIndex, *key, mode);
+ dict->set(index + Dictionary::kEntryValueIndex, *value, mode);
PropertyCell::cast(*value)->set_property_details(details);
}
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698