Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: net/cert/internal/verify_certificate_chain_unittest.cc

Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove allowance of invalid serial numbers for cast roots Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain_pkits_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain_unittest.cc
diff --git a/net/cert/internal/verify_certificate_chain_unittest.cc b/net/cert/internal/verify_certificate_chain_unittest.cc
index 4cd03c08901b63e33dd8add3a3ef8cef90cf6932..9103f12f3df0298ae230c4f5392d87f32e607e35 100644
--- a/net/cert/internal/verify_certificate_chain_unittest.cc
+++ b/net/cert/internal/verify_certificate_chain_unittest.cc
@@ -77,7 +77,7 @@ void ReadTestFromFile(const std::string& file_name,
chain->push_back(block_data);
} else if (block_type == kTrustedCertificateHeader) {
scoped_refptr<ParsedCertificate> cert(
- ParsedCertificate::CreateFromCertificateCopy(block_data));
+ ParsedCertificate::CreateFromCertificateCopy(block_data, {}));
ASSERT_TRUE(cert);
trust_store->AddTrustedCertificate(std::move(cert));
} else if (block_type == kTimeHeader) {
@@ -109,7 +109,8 @@ void RunTest(const char* file_name) {
for (const auto& cert_der : chain) {
ASSERT_TRUE(net::ParsedCertificate::CreateAndAddToVector(
reinterpret_cast<const uint8_t*>(cert_der.data()), cert_der.size(),
- net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE, &input_chain));
+ net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE, {},
+ &input_chain));
}
SimpleSignaturePolicy signature_policy(1024);
« no previous file with comments | « net/cert/internal/verify_certificate_chain_pkits_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698