Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/cert/internal/verify_certificate_chain_pkits_unittest.cc

Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove allowance of invalid serial numbers for cast roots Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parsed_certificate.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain_pkits_unittest.cc
diff --git a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
index 6925f64d48b038d3c157d1c1d0f0b053725328eb..4c543f46baba31fffd125ddd57299cf5720f75ea 100644
--- a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
+++ b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
@@ -55,7 +55,7 @@ class VerifyCertificateChainPkitsTestDelegate {
// First entry in the PKITS chain is the trust anchor.
TrustStore trust_store;
scoped_refptr<ParsedCertificate> anchor(
- ParsedCertificate::CreateFromCertificateCopy(cert_ders[0]));
+ ParsedCertificate::CreateFromCertificateCopy(cert_ders[0], {}));
EXPECT_TRUE(anchor);
if (anchor)
trust_store.AddTrustedCertificate(std::move(anchor));
@@ -67,7 +67,7 @@ class VerifyCertificateChainPkitsTestDelegate {
if (!net::ParsedCertificate::CreateAndAddToVector(
reinterpret_cast<const uint8_t*>(cert_ders[i].data()),
cert_ders[i].size(),
- net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE,
+ net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE, {},
&input_chain)) {
ADD_FAILURE() << "cert " << i << " failed to parse";
return false;
« no previous file with comments | « net/cert/internal/parsed_certificate.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698