net/cert/internal/cert_issuer_source_aia_unittest.cc - Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/cert_issuer_source_aia_unittest.cc

Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove allowance of invalid serial numbers for cast roots Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/internal/cert_issuer_source_aia_unittest.cc

diff --git a/net/cert/internal/cert_issuer_source_aia_unittest.cc b/net/cert/internal/cert_issuer_source_aia_unittest.cc

index 31b257720fb747bc6a70d1eef39fbf1b3f4d06b3..455cf669b3a5bc7f660c4d1617a7ac05aa19030c 100644

--- a/net/cert/internal/cert_issuer_source_aia_unittest.cc

+++ b/net/cert/internal/cert_issuer_source_aia_unittest.cc

@@ -38,7 +38,7 @@ using ::testing::StrictMock;

"CERTIFICATE", &der);

if (!r)

return r;

- *result = ParsedCertificate::CreateFromCertificateCopy(der);

+ *result = ParsedCertificate::CreateFromCertificateCopy(der, {});

if (!*result)

return ::testing::AssertionFailure() << "CreateFromCertificateCopy failed";

return ::testing::AssertionSuccess();

« no previous file with comments | « net/cert/internal/cert_issuer_source_aia.cc ('k') | net/cert/internal/cert_issuer_source_static_unittest.cc » ('j') | no next file with comments »