net/cert/internal/cert_issuer_source_aia.cc - Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/cert_issuer_source_aia.cc

Issue 2079273004: Allow Cast certificates to have serial numbers greater than 20 bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove allowance of invalid serial numbers for cast roots Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test/data/cast_certificate/certificates/intermediate_serialnumber_toolong.pem ('k') | net/cert/internal/cert_issuer_source_aia_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/cert_issuer_source_aia.cc

diff --git a/net/cert/internal/cert_issuer_source_aia.cc b/net/cert/internal/cert_issuer_source_aia.cc

index d948a33c0b97c5d84a120f8f833635813ada6396..4dacc340467d71e7956df78c9d30758126adcdcc 100644

--- a/net/cert/internal/cert_issuer_source_aia.cc

+++ b/net/cert/internal/cert_issuer_source_aia.cc

@@ -89,7 +89,7 @@ void AiaRequest::OnFetchCompleted(Error error,

// bytes.

if (!ParsedCertificate::CreateAndAddToVector(

fetched_bytes.data(), fetched_bytes.size(),

- ParsedCertificate::DataSource::INTERNAL_COPY, &results_)) {

+ ParsedCertificate::DataSource::INTERNAL_COPY, {}, &results_)) {

// TODO(mattm): propagate error info.

LOG(ERROR) << "Error parsing AIA data";

}