Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 2079273003: Revert of Refactor CpuProfiler. (Closed)

Created:
4 years, 6 months ago by lpy
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor CpuProfiler. (patchset #13 id:240001 of https://codereview.chromium.org/2053523003/ ) Reason for revert: MIPS compilation error. Original issue's description: > Refactor CpuProfiler. > > Currently CpuProfiler is a subclass of CodeEventListener, it listens code events > from Logger, constructs and stores CodeEventsContainer. This patch is part of > the effort to split the logic of CodeEventListener as ProfilerListener out of > the profiling functionality logic in CpuProfiler. A ProfilerListener will listen > to code events, construct code event to CodeEventsContainer and pass it to code > event handler. > > The reason we refactor CpuProfiler is that eventually we want to move > CpuProfiler as part of sampler library and code event listener should stay > inside V8. > > Main changes: > 1. Refactored CpuProfiler into two parts, the CpuProfiler with profling > functionality and the ProfilerListener listening to code events from Logger. > 2. Created CodeEventObserver and made CpuProfiler inherit from it. > ProfilerListener will have a list of observers and call CodeEventHandler once a > code event is created. > 3. Moved code entry list from CodeEntry to ProfilerListener. > > Minor changes: > 1. Moved static code entry as part of CodeEntry. > 2. Added ProfilerListener to Logger. > > BUG=v8:4789 > > Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222 > Cr-Commit-Position: refs/heads/master@{#37112} TBR=alph@chromium.org,jochen@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4789 Committed: https://crrev.com/d6be0bf68a6603bd5a0b78e91c679fd7756a7c94 Cr-Commit-Position: refs/heads/master@{#37113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -644 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/log.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/log.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M src/profiler/cpu-profiler.h View 5 chunks +28 lines, -6 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 4 chunks +290 lines, -22 lines 0 comments Download
M src/profiler/profile-generator.h View 4 chunks +34 lines, -41 lines 0 comments Download
M src/profiler/profile-generator.cc View 7 chunks +41 lines, -41 lines 0 comments Download
D src/profiler/profiler-listener.h View 1 chunk +0 lines, -97 lines 0 comments Download
D src/profiler/profiler-listener.cc View 1 chunk +0 lines, -339 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 12 chunks +26 lines, -48 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 6 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lpy
Created Revert of Refactor CpuProfiler.
4 years, 6 months ago (2016-06-20 17:51:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079273003/1
4 years, 6 months ago (2016-06-20 17:51:55 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-20 17:51:57 UTC) #5
adamk
lgtm
4 years, 6 months ago (2016-06-20 17:52:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079273003/1
4 years, 6 months ago (2016-06-20 17:53:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 17:53:37 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 17:57:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6be0bf68a6603bd5a0b78e91c679fd7756a7c94
Cr-Commit-Position: refs/heads/master@{#37113}

Powered by Google App Engine
This is Rietveld 408576698