Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/profiler/profiler-listener.h

Issue 2079273003: Revert of Refactor CpuProfiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/profiler-listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/profiler-listener.h
diff --git a/src/profiler/profiler-listener.h b/src/profiler/profiler-listener.h
deleted file mode 100644
index 7e24ceaa8629d4e9bd34446f6237c62008ed43fe..0000000000000000000000000000000000000000
--- a/src/profiler/profiler-listener.h
+++ /dev/null
@@ -1,97 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef V8_PROFILER_PROFILER_LISTENER_H_
-#define V8_PROFILER_PROFILER_LISTENER_H_
-
-#include <vector>
-
-#include "src/code-events.h"
-#include "src/profiler/profile-generator.h"
-
-namespace v8 {
-namespace internal {
-
-class CodeEventsContainer;
-
-class CodeEventObserver {
- public:
- virtual void CodeEventHandler(const CodeEventsContainer& evt_rec) = 0;
- virtual ~CodeEventObserver() {}
-};
-
-class ProfilerListener : public CodeEventListener {
- public:
- explicit ProfilerListener(Isolate* isolate);
- ~ProfilerListener() override;
-
- void CallbackEvent(Name* name, Address entry_point) override;
- void CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
- AbstractCode* code, const char* comment) override;
- void CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
- AbstractCode* code, Name* name) override;
- void CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
- AbstractCode* code, SharedFunctionInfo* shared,
- Name* script_name) override;
- void CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
- AbstractCode* code, SharedFunctionInfo* shared,
- Name* script_name, int line, int column) override;
- void CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
- AbstractCode* code, int args_count) override;
- void CodeMovingGCEvent() override {}
- void CodeMoveEvent(AbstractCode* from, Address to) override;
- void CodeDisableOptEvent(AbstractCode* code,
- SharedFunctionInfo* shared) override;
- void CodeDeoptEvent(Code* code, Address pc, int fp_to_sp_delta) override;
- void GetterCallbackEvent(Name* name, Address entry_point) override;
- void RegExpCodeCreateEvent(AbstractCode* code, String* source) override;
- void SetterCallbackEvent(Name* name, Address entry_point) override;
- void SharedFunctionInfoMoveEvent(Address from, Address to) override {}
-
- CodeEntry* NewCodeEntry(
- CodeEventListener::LogEventsAndTags tag, const char* name,
- const char* name_prefix = CodeEntry::kEmptyNamePrefix,
- const char* resource_name = CodeEntry::kEmptyResourceName,
- int line_number = v8::CpuProfileNode::kNoLineNumberInfo,
- int column_number = v8::CpuProfileNode::kNoColumnNumberInfo,
- JITLineInfoTable* line_info = NULL, Address instruction_start = NULL);
-
- void AddObserver(CodeEventObserver* observer);
- void RemoveObserver(CodeEventObserver* observer);
- V8_INLINE bool HasObservers() { return !observers_.empty(); }
-
- const char* GetName(Name* name) {
- return function_and_resource_names_.GetName(name);
- }
- const char* GetName(int args_count) {
- return function_and_resource_names_.GetName(args_count);
- }
- const char* GetFunctionName(Name* name) {
- return function_and_resource_names_.GetFunctionName(name);
- }
- const char* GetFunctionName(const char* name) {
- return function_and_resource_names_.GetFunctionName(name);
- }
-
- private:
- void RecordInliningInfo(CodeEntry* entry, AbstractCode* abstract_code);
- void RecordDeoptInlinedFrames(CodeEntry* entry, AbstractCode* abstract_code);
- Name* InferScriptName(Name* name, SharedFunctionInfo* info);
- V8_INLINE void DispatchCodeEvent(const CodeEventsContainer& evt_rec) {
- for (auto observer : observers_) {
- observer->CodeEventHandler(evt_rec);
- }
- }
-
- StringsStorage function_and_resource_names_;
- std::vector<CodeEntry*> code_entries_;
- std::vector<CodeEventObserver*> observers_;
-
- DISALLOW_COPY_AND_ASSIGN(ProfilerListener);
-};
-
-} // namespace internal
-} // namespace v8
-
-#endif // V8_PROFILER_PROFILER_LISTENER_H_
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/profiler-listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698