Sanitize parsing of color look-up table

Sanitize parsing of color look-up table

BUG=skia:5443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003

Committed: https://skia.googlesource.com/skia/+/0ed057542ce545da57cda92dc09c1da8b5fdc363

[msarett, 2016-06-20 14:13:14]

Description was changed from

==========
Sanitize parsing of color look-up table

BUG=skia:5443
==========

to

==========
Sanitize parsing of color look-up table

BUG=skia:5443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003
==========

[msarett, 2016-06-20 14:13:42]

msarett@google.com changed reviewers:
+ kjlubick@google.com

[kjlubick, 2016-06-20 14:27:23]

https://codereview.chromium.org/2079243003/diff/1/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2079243003/diff/1/src/core/SkColorSpace.cpp#n...
src/core/SkColorSpace.cpp:676: size_t dataLen = len - 20;
Where's the magic number 20 coming from?

[msarett, 2016-06-20 14:44:11]

https://codereview.chromium.org/2079243003/diff/1/src/core/SkColorSpace.cpp
File src/core/SkColorSpace.cpp (right):

https://codereview.chromium.org/2079243003/diff/1/src/core/SkColorSpace.cpp#n...
src/core/SkColorSpace.cpp:676: size_t dataLen = len - 20;
On 2016/06/20 14:27:23, kjlubick wrote:
> Where's the magic number 20 coming from?

20 is the number of bytes preceding the actual color LUT data.  I think Patch
Set 2 makes this much more clear.

[kjlubick, 2016-06-20 14:49:01]

lgtm

[msarett, 2016-06-20 14:50:04]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 14:50:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079243003/20001

[commit-bot: I haz the power, 2016-06-20 15:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 15:06:06]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-06-20 15:07:28]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-06-20 15:07:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079243003/20001

[commit-bot: I haz the power, 2016-06-20 15:08:31]

Description was changed from

==========
Sanitize parsing of color look-up table

BUG=skia:5443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003
==========

to

==========
Sanitize parsing of color look-up table

BUG=skia:5443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003

Committed:
https://skia.googlesource.com/skia/+/0ed057542ce545da57cda92dc09c1da8b5fdc363
==========

[commit-bot: I haz the power, 2016-06-20 15:08:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0ed057542ce545da57cda92dc09c1da8b5fdc363