components/content_settings/core/browser/cookie_settings_unittest.cc - Issue 2078893002: Add callback list to PrefModelAssociator after sync data is loaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/cookie_settings_unittest.cc

Issue 2078893002: Add callback list to PrefModelAssociator after sync data is loaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_domain_scoped_settings

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_request_limiter_unittest.cc ('K') | « components/content_settings/core/browser/DEPS ('k') | components/content_settings/core/browser/host_content_settings_map.h » ('j') | components/content_settings/core/browser/host_content_settings_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/cookie_settings_unittest.cc

diff --git a/components/content_settings/core/browser/cookie_settings_unittest.cc b/components/content_settings/core/browser/cookie_settings_unittest.cc

index 77560e18391cddd0605f185a8a6960eeaf3c30ff..8b8605b5dbd8cd79e6afe602266f2df589a71d15 100644

--- a/components/content_settings/core/browser/cookie_settings_unittest.cc

+++ b/components/content_settings/core/browser/cookie_settings_unittest.cc

@@ -29,7 +29,8 @@ class CookieSettingsTest : public testing::Test {

CookieSettings::RegisterProfilePrefs(prefs_.registry());

HostContentSettingsMap::RegisterProfilePrefs(prefs_.registry());

settings_map_ = new HostContentSettingsMap(

- &prefs_, false /* incognito_profile */, false /* guest_profile */);

+ &prefs_, false /* incognito_profile */, false /* guest_profile */,

+ nullptr /* PrefServiceSyncable* */);

raymes 2016/06/29 03:50:01 nit: same here

lshang 2016/06/30 05:03:35 We've changed to not pass in the pointer, so no ne

cookie_settings_ =

new CookieSettings(settings_map_.get(), &prefs_, "chrome-extension");

}