chrome/browser/download/download_request_limiter_unittest.cc - Issue 2078893002: Add callback list to PrefModelAssociator after sync data is loaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_limiter_unittest.cc

Issue 2078893002: Add callback list to PrefModelAssociator after sync data is loaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_domain_scoped_settings

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map_factory.cc ('k') | components/content_settings.gypi » ('j') | components/content_settings/core/browser/cookie_settings_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_request_limiter_unittest.cc

diff --git a/chrome/browser/download/download_request_limiter_unittest.cc b/chrome/browser/download/download_request_limiter_unittest.cc

index 17d79d1b7ffe32cc0febad5cb9d7fb64d5554a84..80244d371d1e7ac1e0c2f38cf4c3268ecbaae3a2 100644

--- a/chrome/browser/download/download_request_limiter_unittest.cc

+++ b/chrome/browser/download/download_request_limiter_unittest.cc

@@ -151,7 +151,7 @@ class DownloadRequestLimiterTest : public ChromeRenderViewHostTestHarness {

content_settings_ = new HostContentSettingsMap(

profile_->GetPrefs(), false /* incognito_profile */,

- false /* guest_profile */);

+ false /* guest_profile */, nullptr /* PrefServiceSyncable* */);

raymes 2016/06/29 03:50:01 nit: usually just put the name of the variable in

lshang 2016/06/30 05:03:35 We've changed to not pass in the pointer, so no ne

DownloadRequestLimiter::SetContentSettingsForTesting(

content_settings_.get());

}