Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2078783002: Move ifx_renderdevicedriver to a separate file to share (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com, caryclark
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move ifx_renderdevicedriver to a separate file to share Move ifx_renderdevicedriver class to its own file to share with multiple devices to reduce code duplication. Committed: https://pdfium.googlesource.com/pdfium/+/095d346ff71ebe0385dfe7fa77baad6a1ce91fcb

Patch Set 1 : base #

Patch Set 2 : fix #

Patch Set 3 : rebase on 'mac skia fix' #

Patch Set 4 : rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -285 lines) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.h View 2 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 3 chunks +2 lines, -92 lines 0 comments Download
M core/fxge/apple/apple_int.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 2 3 1 chunk +8 lines, -12 lines 0 comments Download
M core/fxge/ge/fx_ge_device.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A core/fxge/ifx_renderdevicedriver.cpp View 1 chunk +92 lines, -0 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 2 3 1 chunk +0 lines, -87 lines 0 comments Download
M core/fxge/include/fx_ge_win32.h View 1 chunk +3 lines, -0 lines 0 comments Download
A core/fxge/include/ifx_renderdevicedriver.h View 1 chunk +104 lines, -0 lines 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 2 3 2 chunks +1 line, -83 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/win32_int.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Wei Li
for review, pls.
4 years, 6 months ago (2016-06-20 17:58:38 UTC) #3
dsinclair
lgtm
4 years, 6 months ago (2016-06-20 18:05:08 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2075343002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-20 18:05:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078783002/80001
4 years, 6 months ago (2016-06-21 18:24:08 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:24:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/095d346ff71ebe0385dfe7fa77baad6a1ce9...

Powered by Google App Engine
This is Rietveld 408576698