Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2078453002: Speed up testing. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@visit_for_effect
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -218 lines) Patch
M lib/kernel.dart View 10 chunks +18 lines, -24 lines 0 comments Download
M lib/src/rastak.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/rastask.dart View 3 chunks +96 lines, -5 lines 0 comments Download
M lib/src/run_batch.dart View 5 chunks +30 lines, -83 lines 0 comments Download
M lib/src/run_single.dart View 1 chunk +4 lines, -81 lines 1 comment Download
M test/kernel/kernel_test.dart View 5 chunks +46 lines, -24 lines 0 comments Download

Depends on Patchset:

Issue 2070143002 Patch 1

Messages

Total messages: 5 (2 generated)
ahe
Before: real 2m24.764s user 2m53.186s sys 0m12.728s After: real 0m48.160s user 0m57.909s sys 0m2.740s Of ...
4 years, 6 months ago (2016-06-16 11:06:27 UTC) #2
kasperl
LGTM. Very cool cleanup and speedup. https://codereview.chromium.org/2078453002/diff/1/lib/src/run_single.dart File lib/src/run_single.dart (right): https://codereview.chromium.org/2078453002/diff/1/lib/src/run_single.dart#newcode27 lib/src/run_single.dart:27: return runOne(globalOptions); Very ...
4 years, 6 months ago (2016-06-16 11:14:49 UTC) #3
ahe
4 years, 6 months ago (2016-06-16 13:34:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
01cd3670c05efe14824900c70488f2fb86194cff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698