Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2070143002: Track void context. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@visit_for_value
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Track void context. Fixes #10. BUG=https://github.com/dart-lang/rasta/issues/10 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/e7b66a00bed4dea5edafb04c83709c07a6a4944e

Patch Set 1 #

Patch Set 2 : Merged with ad52721ca12cbb5c47e968ae2070408e1fef7017 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -173 lines) Patch
M lib/kernel_visitor.dart View 1 34 chunks +72 lines, -36 lines 0 comments Download
M test/kernel/kernel_test.dart View 5 chunks +17 lines, -6 lines 0 comments Download
A + test/kernel/regression/for_loop.dart View 1 chunk +6 lines, -4 lines 0 comments Download
A test/kernel/regression/for_loop.dart.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M test/kernel/regression/static.dart.txt View 2 chunks +20 lines, -20 lines 0 comments Download
M test/kernel/regression/super.dart.txt View 7 chunks +58 lines, -58 lines 0 comments Download
M test/kernel/regression/type_literals.dart.txt View 1 chunk +49 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
4 years, 6 months ago (2016-06-15 20:35:01 UTC) #2
kasperl
LGTM. Nice and fairly straight forward.
4 years, 6 months ago (2016-06-16 09:08:22 UTC) #3
ahe
4 years, 6 months ago (2016-06-16 13:33:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e7b66a00bed4dea5edafb04c83709c07a6a4944e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698