Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2078393002: [gn] Default to ninja on all platforms (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
Michael Achenbach, Nico, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Default to ninja on all platforms This makes sure we use ninja everywhere if not stated otherwise explicitly. BUG=chromium:474921 Committed: https://crrev.com/3643f7b1240fc4dfbb73e39e4b25fade4da36af3 Cr-Commit-Position: refs/heads/master@{#37095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gypfiles/gyp_environment.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Achenbach
PTAL. Ports: https://cs.chromium.org/chromium/src/build/gyp_environment.py?l=27
4 years, 6 months ago (2016-06-20 09:15:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078393002/1
4 years, 6 months ago (2016-06-20 09:16:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 09:41:57 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 09:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078393002/1
4 years, 6 months ago (2016-06-20 10:03:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 10:05:28 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 10:06:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3643f7b1240fc4dfbb73e39e4b25fade4da36af3
Cr-Commit-Position: refs/heads/master@{#37095}

Powered by Google App Engine
This is Rietveld 408576698