Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: gypfiles/gyp_environment.py

Issue 2078393002: [gn] Default to ninja on all platforms (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/gyp_environment.py
diff --git a/gypfiles/gyp_environment.py b/gypfiles/gyp_environment.py
index 7a4e62214826881d5c30d7cacea600dbed1bd156..76ae841ffb6a0882a6ea9a9238af0c6b5b752560 100644
--- a/gypfiles/gyp_environment.py
+++ b/gypfiles/gyp_environment.py
@@ -31,6 +31,7 @@ def apply_gyp_environment(file_path=None):
supported_vars = ( 'V8_GYP_FILE',
'V8_GYP_SYNTAX_CHECK',
'GYP_DEFINES',
+ 'GYP_GENERATORS',
'GYP_GENERATOR_FLAGS',
'GYP_GENERATOR_OUTPUT', )
for var in supported_vars:
@@ -51,4 +52,9 @@ def set_environment():
# Update the environment based on v8.gyp_env
gyp_env_path = os.path.join(os.path.dirname(V8_ROOT), 'v8.gyp_env')
apply_gyp_environment(gyp_env_path)
+
+ if not os.environ.get('GYP_GENERATORS'):
+ # Default to ninja on all platforms.
+ os.environ['GYP_GENERATORS'] = 'ninja'
+
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698