android_webview/browser/browser_view_renderer.h - Issue 2078383004: Add a BrowserViewRenderer unittest for compositor switch logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 2078383004: Add a BrowserViewRenderer unittest for compositor switch logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/browser_view_renderer.h

diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h

index 0a46c0bd5aacc25d44779b3f2c0d3ac66f8b3a44..46dbe62b91a6e62ec71c8737472ccd6fd36fcc8f 100644

--- a/android_webview/browser/browser_view_renderer.h

+++ b/android_webview/browser/browser_view_renderer.h

@@ -138,6 +138,9 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient,

void SetActiveCompositorID(const CompositorID& compositor_id);

+ // Visible for testing.

+ content::SynchronousCompositor* compositor() const { return compositor_; }

boliu 2016/06/21 17:29:47 GetCurrent/ActiveCompositorForTesting

hush (inactive) 2016/06/21 21:27:25 Done.

private:

void SetTotalRootLayerScrollOffset(const gfx::Vector2dF& new_value_dip);

bool CanOnDraw();

« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer_unittest.cc » ('j') | android_webview/browser/browser_view_renderer_unittest.cc » ('J')