Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Side by Side Diff: android_webview/browser/browser_view_renderer.h

Issue 2078383004: Add a BrowserViewRenderer unittest for compositor switch logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 const gfx::Vector2dF& current_fling_velocity) override; 131 const gfx::Vector2dF& current_fling_velocity) override;
132 132
133 // CompositorFrameProducer overrides 133 // CompositorFrameProducer overrides
134 void OnParentDrawConstraintsUpdated( 134 void OnParentDrawConstraintsUpdated(
135 CompositorFrameConsumer* compositor_frame_consumer) override; 135 CompositorFrameConsumer* compositor_frame_consumer) override;
136 void RemoveCompositorFrameConsumer( 136 void RemoveCompositorFrameConsumer(
137 CompositorFrameConsumer* compositor_frame_consumer) override; 137 CompositorFrameConsumer* compositor_frame_consumer) override;
138 138
139 void SetActiveCompositorID(const CompositorID& compositor_id); 139 void SetActiveCompositorID(const CompositorID& compositor_id);
140 140
141 // Visible for testing.
142 content::SynchronousCompositor* compositor() const { return compositor_; }
boliu 2016/06/21 17:29:47 GetCurrent/ActiveCompositorForTesting
hush (inactive) 2016/06/21 21:27:25 Done.
143
141 private: 144 private:
142 void SetTotalRootLayerScrollOffset(const gfx::Vector2dF& new_value_dip); 145 void SetTotalRootLayerScrollOffset(const gfx::Vector2dF& new_value_dip);
143 bool CanOnDraw(); 146 bool CanOnDraw();
144 bool CompositeSW(SkCanvas* canvas); 147 bool CompositeSW(SkCanvas* canvas);
145 std::unique_ptr<base::trace_event::ConvertableToTraceFormat> 148 std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
146 RootLayerStateAsValue(const gfx::Vector2dF& total_scroll_offset_dip, 149 RootLayerStateAsValue(const gfx::Vector2dF& total_scroll_offset_dip,
147 const gfx::SizeF& scrollable_size_dip); 150 const gfx::SizeF& scrollable_size_dip);
148 151
149 void ReturnUnusedResource(std::unique_ptr<ChildFrame> frame); 152 void ReturnUnusedResource(std::unique_ptr<ChildFrame> frame);
150 void ReturnResourceFromParent( 153 void ReturnResourceFromParent(
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 gfx::Vector2dF overscroll_rounding_error_; 218 gfx::Vector2dF overscroll_rounding_error_;
216 219
217 ParentCompositorDrawConstraints external_draw_constraints_; 220 ParentCompositorDrawConstraints external_draw_constraints_;
218 221
219 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer); 222 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer);
220 }; 223 };
221 224
222 } // namespace android_webview 225 } // namespace android_webview
223 226
224 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 227 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698