Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2078333002: Revert of [turbofan] Introduce CheckUnless. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Introduce CheckUnless. (patchset #1 id:1 of https://codereview.chromium.org/2080113002/ ) Reason for revert: [Sheriff] Speculative revert: Seems to lead to devtools crashes: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/5259 Original issue's description: > [turbofan] Introduce CheckUnless. > > Similarly to CheckIf, CheckUnless is a deoptimization without a specific > frame state. A frame state is assigned during effect-control linearization > (and CheckUnless is turned into DeoptimizeUnless). > > At the moment, the new operator is only used at one place in native context > specialization, but we should use it everywhere. The advantage of > CHeckUnless is that it avoids non-truncating uses of values by frame > states. This particular change is aimed at Octane's crypto, where this > enables to turn one NumberMultiply into Int32Mul, and thus improve > the score by more than 10% (it also needs minus zero truncation and > typing to be improved, but those CLs are already in flight). > > BUG=v8:4470 > R=bmeurer@chromium.org > > Committed: https://crrev.com/85fde59d538e0dcaf461108086c2f7cf904f567a > Cr-Commit-Position: refs/heads/master@{#37085} TBR=bmeurer@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Committed: https://crrev.com/46c21b2c717d4b249d556305deb61515f9f7603d Cr-Commit-Position: refs/heads/master@{#37090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -43 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [turbofan] Introduce CheckUnless.
4 years, 6 months ago (2016-06-20 07:40:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078333002/1
4 years, 6 months ago (2016-06-20 07:40:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 07:40:57 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 07:42:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c21b2c717d4b249d556305deb61515f9f7603d
Cr-Commit-Position: refs/heads/master@{#37090}

Powered by Google App Engine
This is Rietveld 408576698